Add tests for OAuth2 Authentication and Identity Provider - Githubissues

camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.

https://camunda.com/

Apache License 2.0

4.12k stars 1.56k forks source link

Add tests for OAuth2 Authentication and Identity Provider #4567

Open danielkelemen opened 2 months ago

danielkelemen commented 2 months ago

Acceptance Criteria (Required on creation)

Test OAuth2 classes:
- CamundaBpmSpringSecurityDisableAutoConfiguration is active when no oauth2 configuration is present.
- CamundaSpringSecurityOAuth2AutoConfiguration is active when oauth2 configuration is present.
- OAuth2AuthenticationProvider passes Spring Security user to Camunda Webapps Authentication.
- OAuth2IdentityProviderPlugin configures groups correctly from claims. Works as a normal DB provider, too.

Hints

Links

Breakdown

### PRs
- [ ] https://github.com/camunda/camunda-bpm-platform/pull/4576

danielkelemen commented 1 month ago

TODOs

Mocking the login seems to be working but:
- Application properties still need to contain a correct oauth2 issuer url which is not good as it's an external dependency.
Requests to /api return 404
Once these are resolved, we should add more tests to verify more use-cases.