camunda / camunda-bpm-platform

Flexible framework for workflow and decision automation with BPMN and DMN. Integration with Quarkus, Spring, Spring Boot, CDI.
https://camunda.com/
Apache License 2.0
4.13k stars 1.56k forks source link

Implement a test to ensure DB tables are created and queried using all uppercase characters #4591

Open mboskamp opened 2 months ago

mboskamp commented 2 months ago

Acceptance Criteria (Required on creation)

We have tests in all places where there is interaction with DB tables to ensure table names are always upper-case.

Background: DBs can be configured using a case-sensitive collation. We need to ensure that this won't break functionality in Camunda Platform 7.

Hints

Known places are:

There are tests for column names already:

Links

Breakdown

### Pull Requests

Dev2QA handover

vizai commented 2 months ago

I am going to work on this.

mboskamp commented 2 months ago

@vizai, Awesome to hear that you want to contribute this enhancement. I was thinking of adding a test similar to what I did for this ticket. Specifically, you can check out the test for lower-case column names.

vizai commented 2 months ago

@mboskamp , Yes I am referring the previous story to bring similar logic for table names. Also, adding "upgrade" folder in the scanned folders for these tests:

public static String[] SCANNED_FOLDERS = { "org/camunda/bpm/engine/impl/mapping/entity/", "org/camunda/bpm/engine/db/create", "org/camunda/bpm/engine/db/drop", "org/camunda/bpm/engine/db/upgrade" "org/camunda/bpm/engine/db/liquibase/baseline" };

mboskamp commented 1 month ago

Hey @vizai, How is it going? What is the status of your contribution? Do you need any input/assistance?

vizai commented 1 month ago

I have fix ready, verified. I will create PR. I am using the regex expression to find the table names starts with "act_"