Embed Camunda WebApp

[hawky-4s-]

https://github.com/Zapata/camunda-spring-boot-embedded is embedding the camunda-webapp as a web-jar. Maybe we can do the same? WDYT?

[osteinhauer]

The trick is that in gradle build the war ist repackaged as webjar (https://github.com/Zapata/camunda-spring-boot-embedded/blob/master/camunda-webapp-webjar/build.gradle).

IMHO: A spring boot starter should never do such "hacks". And the example I have provided is very ugly too.

But the idea to have an webjar is great. We should ask if the webapp module can provided an webjar.

[hawky-4s-]

Valid point. I'll take care of that.

[osteinhauer]

Thanks for that. Until there is no idea to include the webapp in a nice way the starter should not be used by anyone.

[jangalinski]

Well, then this should not be part of the master branch anymore ... we should aim for a soon POC release so we can play around with the stack, and everything thats not supposed to work is just confusing ... so maybe create a feature branch and put it on hold?

[osteinhauer]

feature branch is a good idea. We should do that after we have all agreed to the multi module.

[jangalinski]

Any news on the web jar deliverable from platform? Is it realistic to have this in 7.4? What needs to be done?

[meyerdan]

Pull request ? :=)

[ghost]

Basically just creating a maven project inside the camunda-webapp project 1, which repackages the bundled webapp as web-jar as in 2.

On 09.09.15 11:25, Jan Galinski wrote:

Any news on the web jar deliverable from platform? Is it realistic to have this in 7.4? What needs to be done?

— Reply to this email directly or view it on GitHub https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/3#issuecomment-138852573.

[jangalinski]

I just created https://github.com/camunda/camunda-bpm-webapp/pull/5

Please check my remarks, I am not quite happy with the result, but cant figure out whats missing, I guess thats because I need some sleep ...

[jangalinski]

If you have time, please check the PR https://github.com/camunda/camunda-bpm-webapp/pull/5 comments .... Daniel is asking me if the generated output is what I need, and honestly: I do not know ... I suppose there is some stuff missing ...

[jangalinski]

Even when we have the webjar, this will only be applicable for 7.4, so I moved it to milestone 2.0

[jangalinski]

I started the following: provide a camunda-bpm-spring-boot-webjar inside this repo. This is exactly the same as the webjar PR for 7.4, but we generate it ourselves, so we can use it with 7.3 right away. for 7.4 this can be removed. I also locally created a c-b-s-b-starter-webapp where this webjar is used and am currently integrating the ServletFilter from the zapata approach (using Christians branch). Hope to get this running soon.

[abrass]

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4 including the cockpit as a web-jar?

greetz

Anton

[ghost]

Hi Thomas,

There is an ongoing PR for 7.4 webapp and we will probably build a 7.3 Version especially for the Spring Boot Starter inside this project.

Cheers Christian

Gesendet mit AquaMail für Android http://www.aqua-mail.com

Am 3. Oktober 2015 16:45:49 schrieb Anton BNrass notifications@github.com:

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4 including the cockpit as a web-jar?

greetz

Anton

---

Reply to this email directly or view it on GitHub: https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/3#issuecomment-145254142

[osteinhauer]

If you don't want to wait until Cockpit is supported you can have a look at https://github.com/camunda/camunda-bpm-spring-boot-starter/tree/Embed_Camunda_WebApp_%233/camunda-webapp-spring-boot-starter and do the configuration on your own. Be aware that this isn't nice at all. That is why it isn't integrated yet. See the discussion above.

Am 03.10.2015 um 16:45 schrieb Anton BNrass notifications@github.com:

Would be great to have this feature.

Is there a PR for spring boot starter for any camunda version, 7.3 or 7.4 including the cockpit as a web-jar?

greetz

Anton

— Reply to this email directly or view it on GitHub.

[hawky-4s-]

Okay, I merged the PR on Camunda-Webapp

[osteinhauer]

The webjar is integrated now but not tested well.

Beside the webjar isn't bundled very nice:

The resources should be located in META-INF/resources like http://www.webjars.org and https://spring.io/blog/2014/01/03/utilizing-webjars-in-spring-boot describes. Having that it wouldn't be necessary to add all resources from the classpath root like CamundaBpmWebappAutoConfiguration.java does: registry.addResourceHandler("/**").addResourceLocations("classpath:/")

Maybe another one has an idea to get the resources served in a better way?

[osteinhauer]

This feature seems to work and will be contained in release 1.1.0 Bugs and features will go in separate issues

[jangalinski]

Question (cant test it myself right now): If I use starter-webapp and starter-rest together, can I still access the rest-api, or is that masked by the webapp resource?

[osteinhauer]

Just created an example (rest-api-and-webapp https://github.com/osteinhauer/camunda-spring-boot-starter-examples/tree/master/rest-api-and-webapp) because I was interested too. I figured out that both can be used in parallel.

Am 20.01.2016 um 10:01 schrieb Jan Galinski notifications@github.com:

Question (cant test it myself right now): If I use starter-webapp and starter-rest together, can I still access the rest-api, or is that masked by the webapp resource?

— Reply to this email directly or view it on GitHub https://github.com/camunda/camunda-bpm-spring-boot-starter/issues/3#issuecomment-173134421.