camunda / camunda-bpmn-js-behaviors

Camunda behaviors for bpmn-js
MIT License
5 stars 3 forks source link

Support zeebe:ExecutionListener #76

Closed barmac closed 3 months ago

barmac commented 4 months ago

This PR adds support for zeebe:ExecutionListener according to the support table in https://github.com/camunda/camunda-docs/pull/4017

In the implementation, we don't care about element types which are not currently supported in Camunda, e.g.

barmac commented 4 months ago

Looks good to me!

Just to clarify, we allow end listeners for all Escalation events, because we can not verify if the escalation will be interrupting from the element itself, correct?

cf. https://github.com/camunda/camunda-docs/pull/4017/files#diff-a74161458f7314ea1d7e09cd3e91e96f454af8faf451ca49793dd70ae39fbe9dR65

Correct. And IMO the order in which the events are configured should not affect the EL configuration.

I'd like to hold this PR until the discussion from https://camunda.slack.com/archives/GP70M0J6M/p1720185492298049 is resolved. Can you please have a look too? This PR implements (1) but I'm not so sure about this anymore.

barmac commented 3 months ago

We will enforce the event types, so this PR needs to be merged.