search

camunda / camunda-bpmn-moddle

Camunda moddle extensions for BPMN 2.0
MIT License
64 stars 40 forks source link

fix(variableEvent): changing from variableEvent tovVariableEvents pro… #58

Closed prithviraj-maurya closed 3 years ago

prithviraj-maurya commented 3 years ago

fixes #355 #388

prithviraj-maurya commented 3 years ago

Is it fine now ??

pinussilvestrus commented 3 years ago

We want to have one single commit fixing the issue to keep the commit history clean. Therefore it would be great to squash all 3 commits in this PR together to a single one with the commit message I proposed.

pinussilvestrus commented 3 years ago

I merged it via cd4a417c1ee7831646f896d2360854aee7ee1ad3, thanks a lot !

prithviraj-maurya commented 3 years ago

Can we close updatream PR as well ? https://github.com/bpmn-io/bpmn-js-properties-panel/pull/388

On Mon, Oct 26, 2020 at 1:10 PM Niklas Kiefer notifications@github.com wrote:

Closed #58 https://github.com/camunda/camunda-bpmn-moddle/pull/58.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/camunda/camunda-bpmn-moddle/pull/58#event-3919286470, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLI5TSV4IFR2CXH6BP2BT3SMURW7ANCNFSM4S5M2U7Q .

pinussilvestrus commented 3 years ago

I am on it. I have to release the moddle lib and integrate it properly.

prithviraj-maurya commented 3 years ago

Sure do let me know thank you.

On Mon, Oct 26, 2020, 13:15 Niklas Kiefer notifications@github.com wrote:

I am on it. I have to release the moddle lib and integrate it properly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/camunda/camunda-bpmn-moddle/pull/58#issuecomment-716372349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLI5TSAEIZQ3FIAIWBL7HTSMUSJ5ANCNFSM4S5M2U7Q .