fix: remove start event initiator moved to or created within subprocess

camunda / camunda-bpmn-moddle

Camunda moddle extensions for BPMN 2.0

MIT License

64 stars 40 forks source link

fix: remove start event initiator moved to or created within subprocess #75

Closed smbea closed 3 years ago

smbea commented 3 years ago

Closes #74

marstamm commented 3 years ago

I noticed that the Issue is linked in the PR description, but not in the commits. This makes it harder to find the corresponding issue once the PR is merged. Please consider adding it to one of your commits as well (cf. Definition of Done)

smbea commented 3 years ago

Changes overview:

Added three conditions for property removal
Added test case for when shape with initiator property is moved within subprocess
Removed some console.log's I accidentally left behind
[On commits] Started adding issue link in commits' descriptions

barmac commented 3 years ago

Congratulations on your first contribution 🎉

nikku commented 3 years ago

:tada: