778 Update conditional start event on parent change

camunda / camunda-bpmn-moddle

Camunda moddle extensions for BPMN 2.0

MIT License

64 stars 40 forks source link

778 Update conditional start event on parent change #77

Closed smbea closed 3 years ago

smbea commented 3 years ago

Changes overview:

@barmac I updated the way the objects were being modified, as we had talked about (using bpmnFactory and moddleCopy to create and modify a copy of each object)

@pinussilvestrus I fixed the consistency discrepancies and updated the test diagram to include more than one eventDefinition in the conditional startEvent

smbea commented 3 years ago

Changes summary:

The conditions for the property removal were changed according to the comments made
Copy of eventDefinitions object and parent check is now only done once
Flag was added to check if there was a need to update the eventDefinitions, instead of always updating
Missing test case was added

barmac commented 3 years ago

I've renamed a couple of variables, changed formatting, and squashed the commits. Ready to merge :)