search

camunda / camunda-dmn-js

Embeddable Camunda modeling distributions based on dmn-js
MIT License
6 stars 3 forks source link

Example `npm start` is broken (literal expression editor does not open) #119

Closed nikku closed 2 months ago

nikku commented 2 months ago

The example in npm start is broken, literal expression editor blows up.

Steps to reproduce

Capture (demo)

capture Z10pKn_optimized

Originally posted by @nikku in https://github.com/camunda/camunda-dmn-js/issues/118#issuecomment-2304289151

barmac commented 2 months ago

Thanks for reporting. I'll have a look at this.

barmac commented 2 months ago

The example is a valid DMN, and the issue is within the dmn-js-literal-expression library. In that project, we assume that the decision contains a variable element which is optional in DMN, but always created in dmn-js-drd. Temporary solution is to change the example to meet the assumption. The correct solution would be to properly handle missing variable in literal expression: add it if missing, and make the name follow the decision name. However, I believe we will replace dmn-js-literal-expression with dmn-js-boxed-expression at some point of time, so for now I will only implement the diagram change.