Closed MarvinLudwig closed 8 years ago
Hi Marvin,
I am very sorry for the late response.
I will have a look into your pull request next week.
Thank you for your pull request.
Cheers, Roman
Hi Marvin,
Once again, sorry for the late response. However, I had a look into your pull request.
There are some glitches:
(1) After overwriting an existing bpmn file diagram it is not possible to execute Save As...
anymore:
Given:
diagram.bpmn
and diagram1.bpmn
in the same folderWhen:
File
> Open File...
> choose diagram.bpmn
File
> Save As...
> diagram1.bpmn
> Confirm dialog to overwrite existing file with Yes
File
> Save As...
Then:
SaveAsHandler#getOldFile()
throws a NullPointerException
.
(2) Diagram is marked as "changed":
Given:
diagram.bpmn
When:
diagram.bpmn
File
> Save As...
> change filename to diagram12.bpmn
> confirm the dialog with Ok
Then:
The title is updated to diagram12
and *
marks the diagram as changed. So if I close the diagram I get a dialog, that the resource has changed.
(3) Title changes to old value:
Given:
diagram.bpmn
When:
diagram.bpmn
(title is set to diagram
)File
> Save As...
> change filename to diagram12.bpmn
> confirm the dialog with Ok
(title is set to diagram12
)Then:
The title of the diagram changes from diagram12
back to diagram
.
(4) Cannot open original diagram in parallel:
Given:
diagram.bpmn
When:
diagram.bpmn
File
> Save As...
> change filename to diagram12.bpmn
> confirm the dialog with Ok
diagram.bpmn
once againThen:
The diagram12
stays open and diagram.bpmn
is not opened.
And one last question: Does 1 also work on windows?
Could you fix the mentioned glitches please?
Cheers, Roman
Hi Marvin,
I close this pull request since you did not respond.
Feel free to reopen this pull request or to create a new pull request if you fixed the mentioned glitches.
Thanks!
Cheers, Roman
This adresses issue #16 by implementing a Save As file dialog for external files. For files that are within the workspace the standard dialog is still used.