camunda / camunda-modeler-linter-plugin

Check your BPMN diagrams for common issues
37 stars 8 forks source link

Expressions shown as class instead #40

Closed vikkee57 closed 6 months ago

vikkee57 commented 6 months ago

Not sure what's a good repo to post this issue, there are few bpmnlint projects over here, but I observed something that seems like a bug and thought of sharing.

When working on the lint plugin and validating service tasks, I see that the expression property is appearing as class.

You have a service task with implementation type as "expression"

image

But when you try to read this property and debug, it is stored against node.class field?

image
nikku commented 6 months ago

@vikkee57 I'm a little bit confused what your observation has to do with linting? I'd assume you'll observe the same without it.

If you can reproduce your issue in the Camunda Modeler could you create a bug report there, with clear steps to reproduce and expected behavior? Find below a quick test I conducted myself by the context you provided:

capture q7TI1l_optimized

If you have questions on our tooling then the Community Forum may be the right place to answer these.

vikkee57 commented 6 months ago

Thanks a lot for taking a look at my thread @nikku!

Yes no problems with the modeler so far, it is captured correctly. But I suspect there is a possible bug in the lint plugin here?
If you see my second screenshot from IDE, it does not have a equivalent node.expression property. It instead stores the expression against node.class.

So if anyone wanted to write a new lint rule on something related to camunda:expression, we can't?!

nikku commented 6 months ago

@vikkee57 I'm not sure if you added a breakpoint with a cached result or what is going on. Without clear steps to reproduce we'll not be able to follow up on your report.

Using an end-to-end test I reproduced that there is no bug in the modeler itself.

vikkee57 commented 5 months ago

Appreciate you checking this @nikku, I am probably then missing something in my own implementation. I will submit a different issue if I find anything substantial.