Images not found in Plugin

camunda / camunda-modeler-plugins

Plugins for the Camunda Modeler.

167 stars 67 forks source link

Images not found in Plugin #12

Closed pme123 closed 5 years ago

pme123 commented 5 years ago

I tried to do the camunda-modeler-plugin-example.

I also tried darlene.

In both examples the image is not found in the Modeler - the rest of the plugin seems to work.

nikku commented 5 years ago

Which platform are you on?

pme123 commented 5 years ago

Mac OS, I am not sure if I was then already on Mojave.

philippfromme commented 5 years ago

The Darlene plugin has been removed.

nikku commented 5 years ago

@barmac Could you check whether you're able to reproduce this issue?

barmac commented 5 years ago

I will.

barmac commented 5 years ago

@nikku I am able to reproduce this issue.

I get the following error when logo.png is in the plugin directory: Failed to load resource: net::ERR_FILE_NOT_FOUND

Otherwise, it's: GET file:///Users/maciej.barelkowski/Desktop/Camunda%20Modeler%202.2.4.app/Contents/MacOS/plugins//camunda-modeler-plugin-example/logo.png 0 ()

nikku commented 5 years ago

Does the file exist (on disk)?

barmac commented 5 years ago

The errors I pasted are shown in the following situations respectively

File is in the same directory as plugin (~/Library/Application Support/camunda-modeler/plugins/camunda-modeler-plugin-example).
There is no such file.

nikku commented 5 years ago

Further investigation showed that this is a general, not only OSX related issue.

General steps to reproduce:

Put plug-in into ${userData}/plugins directory
Resolving path fails

Requires fix via https://github.com/camunda/camunda-modeler/issues/1135.

nikku commented 5 years ago

Fixed via https://github.com/camunda/camunda-modeler/issues/1135.