Adding new line in DMN Input Expression script field is not consistent with other input fields

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.

https://camunda.com/products/modeler

MIT License

1.5k stars 481 forks source link

Adding new line in DMN Input Expression script field is not consistent with other input fields #1224

Open mschoe opened 5 years ago

mschoe commented 5 years ago

Describe the Bug

To add a new line in the DMN input expression script field I need to press CTRL + ENTER This is not consistent with the standard behavior SHIFT + ENTER

Expected Behavior

Press SHIFT + ENTER for new line

Environment

Please complete the following information:

OS: WIN10
Camunda Modeler Version: 3.0.0-beta-0

pinussilvestrus commented 5 years ago

We already made it consistent inside the dmn table (https://github.com/bpmn-io/dmn-js/issues/337) and decided to do it the CTRL-way, since SHIFT+ENTER is not intended to adding a new line inside a dmn table at all.

I'll close it since it's intended behavior. Feel welcome to re-open if we should discuss about it again.

nikku commented 5 years ago

Let's keep this issue open, as it is indeed a UX issue:

We use SHIFT + ENTER in direct editing and properties panel
We use CTRL + ENTER in the decision table (all inputs)

nikku commented 5 years ago

Long term we should aim to unify the shortcut in all editors / panels.