camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.49k stars 476 forks source link

I have JavaScript error when created flags.json in Resources folder #1363

Closed slizenko closed 5 years ago

slizenko commented 5 years ago

Error message: image

flags.json: { "disable-plugins": false, "disable-adjust-origin": false, "disable-cmmn": false, "disable-dmn": false, "single-instance": false }

Environment:

pinussilvestrus commented 5 years ago

Hi @slizenko , thanks for sharing! This is definitely a bug, I found out that it came with the single-instance flag. I'll have a look at this.

pinussilvestrus commented 5 years ago

Update: I found the issue and opened a pull request (cf. #1364).

After merged, it will prevent the app to crash with the single-instance flag set to false. We should consider shipping a patch release after it 🚀

pinussilvestrus commented 5 years ago

Closes via #1364

@barmac @philippfromme should we ship a patch release with this fix (v3.1.1)?