camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.49k stars 479 forks source link

Keep original viewport when switching back from table to DRD view #1538

Open mschoe opened 4 years ago

mschoe commented 4 years ago

Describe the Bug

When switching between the DRD and a sub view (decision table, literal expression) the DRD viewbox is reset to (0,0) on any sub view change. I'd expect the viewbox to stay where it originally was so that users have a better switching behavior.

Steps to Reproduce

PlacementIssureDRD

Describe the Solution

Additional Context

This has to be fixed in dmn-js

Environment affects all OS modeler v. 3.4.0

nikku commented 4 years ago

From what I understand you're asking for the following:

Keep the current DRD viewport when switching to other editors and back to the DRD. Or in other words, if I centered the diagram, switch to a table, switch back, the diagram should still be centered at the previous position.

Does that summarize your feature request?

mschoe commented 4 years ago

I think the following screencast demonstrates it much better. I would expect that the modeler keeps the the viewport when I switch to the dmn view.

drd_dmn_switch

nikku commented 4 years ago

Thanks for clarifying. A legit feature request. :+1:

mschoe commented 4 years ago

:heart:

iamparthshukla commented 4 years ago

Is this issue up for someone to work on? I would love to give this a try!

techytushar commented 3 years ago

Hey @nikku @pinussilvestrus I would like to work on this, please can you tell in which files I should look into in dmn-js. I tried to figure it out but I am not able to since there are a lot of files.