Deployment should not fail when gateway version cannot be retrieved - Githubissues

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.

https://camunda.com/products/modeler

MIT License

1.47k stars 473 forks source link

Deployment should not fail when gateway version cannot be retrieved #3356

Open barmac opened 1 year ago

barmac commented 1 year ago

Describe the bug

Look at this fragment of code: https://github.com/camunda/camunda-modeler/blob/b7c36854370ff38da3b53ebd22d5e5337039a63c/client/src/plugins/zeebe-plugin/deployment-plugin/DeploymentPlugin.js#L184

The deployment can fail when the call above fails although the gateway version is used for usage tracking only. There is an irregular error triggered from the method: https://camunda.slack.com/archives/CKGH9LR40/p1670850797038149?thread_ts=1670842180.512739&cid=CKGH9LR40

Steps to reproduce

Cannot.

Expected behavior

Code should be fail-safe.

Environment

OS: [e.g. MacOS 10.2, Windows 10]
Camunda Modeler Version: [e.g. 2.0.0]
Execution Platform: [e.g. Camunda Platform, Camunda Cloud]
Installed plug-ins: [...]

Additional context

No response

nikku commented 1 year ago

Great one (hashtag unforgiving).

igpetrov commented 1 year ago

Also related to https://camunda.slack.com/archives/CKGH9LR40/p1671007991163419?thread_ts=1670842180.512739&cid=CKGH9LR40