No validation error on missing input binding source - Githubissues

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.

https://camunda.com/products/modeler

MIT License

1.47k stars 473 forks source link

No validation error on missing input binding source #3359

Open nikku opened 1 year ago

nikku commented 1 year ago

Describe the bug

As a user I can create invalid (empty) input bindings, causing the diagram to become undeployable:

Command 'CREATE' rejected with code 'INVALID_ARGUMENT': Expected to deploy new resources, but encountered the following errors:
'diagram-5.bpmn':
[...]
- Element: Activity_0jjnbx9 > extensionElements > ioMapping > input
    - ERROR: Expected expression but not found.
 [ deploy-error ]

While the deployment fails the error is not indicated in the error panel.

Steps to reproduce

Open diagram_1.bpmn
Deploy to C8 (8.2-alpha) cluster
See deploy error / see no prior error in Problems tab

Expected behavior

Validation indicates that input source (and target) must be provided.
Validation indicates that output source (and target) must be provided.

Environment

OS: any
Camunda Modeler Version: 5.6.0
Execution Platform: Camunda Cloud
Installed plug-ins: camunda-modeler-custom-linter-rules-plugin

Additional context

No response

nikku commented 1 year ago

As we pick this up we must ensure we have a proper interaction between technical property validation and element templates (https://github.com/camunda/camunda-modeler/issues/3360).

nikku commented 1 year ago

CC @christian-konrad