camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.51k stars 484 forks source link

Lint Errors for Element Template Properties Not Selectable in Properties Panel #3896

Open philippfromme opened 1 year ago

philippfromme commented 1 year ago

Describe the bug

Lint errors for element template properties reported by bpmnlint-plugin-camunda-compat are not selectable in the properties panel since the properties panel entry ID is different and @camunda/linting isn't aware of element templates. Instead it assumes that a zeebe:Input error would be selectable in the Inputs group. However, if that input was created by an element template, the properties panel entry would have a different ID.

capture B90nNL_optimized

Steps to reproduce

  1. Apply an element template that creates a zeebe:Input
  2. Enter secrets.FOO which will result in a lint error
  3. Click the lint error in the Problems panel
  4. Properties panel entry not selected

Expected behavior

Properties panel selected.

Environment

Additional context

No response

nikku commented 1 year ago

Moving to ready. We shall address this to deliver a good experience to our users.

nikku commented 1 year ago

Is this a duplicate of https://github.com/camunda/camunda-modeler/issues/3896?

philippfromme commented 1 year ago

An illustration of what is happening:

image

philippfromme commented 1 year ago

Is this a duplicate of #3896?

Sir, this is #3896.

nikku commented 1 year ago

Thanks! Is it a duplicate of https://github.com/camunda/camunda-modeler/issues/3889?

philippfromme commented 1 year ago

Kind of, this issue is just more specific about what causes this issue. We can close one of the two.

philippfromme commented 1 year ago

Possible solution: Provide an API to focus an entry given a property; element templates provider can then override

image

Miro Board: https://miro.com/app/board/uXjVMgBSORk=/?share_link_id=630116056005

CatalinaMoisuc commented 1 year ago

We have no capacity at the moment to work on this and it does not look like a trivial fix, so we leave it in Ready for the next iteration, maybe we have capacity there.