Support collapsed subprocesses in C8

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.

https://camunda.com/products/modeler

MIT License

1.5k stars 481 forks source link

Support collapsed subprocesses in C8 #4020

Closed CatalinaMoisuc closed 10 months ago

CatalinaMoisuc commented 11 months ago

Implementation task for https://github.com/camunda/product-hub/issues/294.

Problem you would like to solve

Camunda 8 (target version pending) is going to support collapsed sub-processes. Our tool should reflect that.

Proposed solution

Enable support for collapsed subprocesses in C8:

[x] Validation allows collapsed sub-processes for 8.4
[x] Validation disallows collapsed sub-process with aligned message Only supported in 8.4 and newer for older Camunda versions.

Follow-up in Web Modeler:

[x] Allow collapsed sub-process modeling (already allowed in Desktop Modeler) - https://github.com/camunda/web-modeler/issues/2969

Alternatives considered

None.

Additional context

We currently support modeling already, but mark the sub-process as "unsupported", using an outdated message:

nikku commented 11 months ago

@CatalinaMoisuc I updated the issue. From what I see we still lack the target version.

CatalinaMoisuc commented 11 months ago

@nikku if I follow the discussions in PHub, it seems that there is no actual change needed in any of the other products, so to me it seems that the target can also be 8.4. if the timeline would work for us given the upcoming FTOs and early code-freeze.

nikku commented 11 months ago

Moving to ready in that case.

CatalinaMoisuc commented 11 months ago

@nikku We also had a quick chat on this in the last weekly and I think this can simply be enabled via camunda-bpmn-js also for C8 as is for C7 and no actual change will be necessary on the Web Modeler side other than integrating the dependency update. Is my assumption correct?

nikku commented 11 months ago

Yes. Cf. the additional details I added to the issue.

CatalinaMoisuc commented 11 months ago

@barmac can you please give a heads-up to the Web team so they can enable it as well and update for the lint rule?

nikku commented 11 months ago

I updated the description, also flagging the follow-up needed in web modeler.

CatalinaMoisuc commented 11 months ago

FYI, follow-up is needed not only because the plugin has to be removed, but we also have to shift the position of the overlay as it is overlapping with some other overlays we have.

barmac commented 11 months ago

I will look into this tomorrow.

barmac commented 10 months ago

This will be completed via:

HanselIdes commented 10 months ago

This looks great for Modeler and Operate!

@crobbins215, one requirement may have been missed In the PDP epic https://github.com/camunda/product-hub/issues/294#issuecomment-1835701940 I added a must-have requirement to explain the limitations in Optimize with collapsed subprocesses. I also added a user story: "As a Developer, I am warned that analysis of the collapsed sub-process is not supported in Optimize", and that hasn't been removed or implemented AFAIK. This could also be done through documentation, but it's your call.

CatalinaMoisuc commented 10 months ago

I don't think we should use linting to tell the user that a feature is not supported in Optimize, collapsed subprocesses - what the user modeled is supported - @crobbins215 I would propose that we ask the Optimize team to document that.

nikku commented 10 months ago

@HanselIdes Let's keep scoping discussions on the PDP epic. I propose we're pragmatic here.