search

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.49k stars 479 forks source link

Add accessible names to the XML/JSON editors #4370

Closed barmac closed 3 months ago

barmac commented 3 months ago

What should we do?

Add accessible names to the XML/JSON editors

Why should we do it?

Child of https://github.com/bpmn-io/internal-docs/issues/909

barmac commented 3 months ago

An additional error is reported in the editors:

image

It is present on the codemirror website as well: https://codemirror.net/

nikku commented 3 months ago

https://github.com/camunda/camunda-modeler/issues/4370#issuecomment-2176268728

This is a false-positive; code mirror editor is absolutely focusable via keyboard. If possible, let's black list this violation.

nikku commented 3 months ago

Closed via https://github.com/camunda/camunda-modeler/pull/4379.