Add accessible names and tabindex to code editors - Githubissues

camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.

https://camunda.com/products/modeler

MIT License

1.47k stars 472 forks source link

Add accessible names and tabindex to code editors #4379

Closed barmac closed 2 weeks ago

barmac commented 2 weeks ago

https://github.com/camunda/camunda-modeler/assets/28307541/d4edf538-e103-42a1-bb01-cbf00878a568

Proposed Changes

This PR:

adds accessible names to the code editors
adds tabindex necessary to satisfy ~~the beast~~ axe-core which currently reports lack of interactive content in the code editor.

Closes #4370

Checklist

To ensure you provided everything we need to look at your PR:

[x] Brief textual description of the changes present
[x] Visual demo attached
[ ] Steps to try out present, i.e. using the @bpmn-io/sr tool
[x] Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}