camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.49k stars 479 forks source link

Validate `bindingType` property (supported in Camunda 8.6+) #4386

Closed jfriedenstab closed 2 months ago

jfriedenstab commented 3 months ago

Problem you would like to solve

The new binding type deployment will only be supported by Zeebe 8.6 or newer. Users should be warned if they're using the new binding type in their BPMN process, but have selected a lower execution platform version.

Proposed solution

Add a new linting rule that warns the user if the binding type selected for a called process, called decision or linked form is not yet supported by the current execution platform version, for example: A <Call Activity> with <Binding: Deployment> is only supported by Camunda 8.6 or newer

Alternatives considered

none

Additional context

wollefitz commented 2 months ago

Update July 24

@jfriedenstab to clarify status of this issue / if it will make it before the 8.6-alpha4 release

barmac commented 2 months ago

I see that this is not implemented yet, so it's not coming as part of 8.6-alpha.4. I think it's quite unfortunate that the users can already use the new property, but are left in the dark about the support of the feature.

barmac commented 2 months ago

I'm moving this to ready.

barmac commented 2 months ago

Assigning @philippfromme as the assignee of https://github.com/camunda/camunda-modeler/issues/4385. Feel free to drop it if you don't have capacity.

jfriedenstab commented 2 months ago

Thanks, @barmac! Is there any chance that this could be implemented in the next days, @philippfromme? Then we could still try to include it in the release.

philippfromme commented 2 months ago

@jfriedenstab I'm on it!

jfriedenstab commented 2 months ago

Great, thank you! 🙂

philippfromme commented 2 months ago

Pull requests incoming:

barmac commented 2 months ago

In that case, we may also include it in https://github.com/camunda/camunda-modeler/pull/4439

philippfromme commented 2 months ago

In that case, we may also include it in #4439

Yes, I'd like that.

barmac commented 2 months ago

I've updated the milestone since this is shipped with the current release.