camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.49k stars 479 forks source link

Edit input/output button flashes when adding new column #4388

Closed marstamm closed 1 month ago

marstamm commented 3 months ago

Describe the bug

When I edit a Decision table and add another coloumn, the edit button flashes briefly. This is unexpected as I can not click on it

Related to https://github.com/bpmn-io/dmn-js/issues/845

Recording 2024-06-20 at 10 49 06

Steps to reproduce

  1. Open a Decision Table
  2. Add a column using the mouse
  3. The Icon briefly flashes

Expected behavior

Either

Environment

Additional context

No response

barmac commented 3 months ago

In the tool, we rely on :focus-within selector to display the button. We should use :focus-visible instead.

barmac commented 3 months ago

:focus-within -> a descendant has focus :focus-visible -> browser "thinks" focus should be displayed

jarekdanielak commented 2 months ago

Fixed upstream in https://github.com/bpmn-io/dmn-js/pull/890