camunda / camunda-modeler

An integrated modeling solution for BPMN, DMN and Forms based on bpmn.io.
https://camunda.com/products/modeler
MIT License
1.51k stars 483 forks source link

Enhance editing entries in new DMN modeler #769

Open benhoffmann opened 6 years ago

benhoffmann commented 6 years ago

Editing single cells could be more intuitive.

modeler-1 12


Tasks:

philippfromme commented 6 years ago

Okay, so:

  1. We decided to not open the context menu automatically on focus since that would be pretty obtrusive.

  2. This is actually a bug. I've created an issue for it.

  3. Do you mean pressing ENTER?

benhoffmann commented 6 years ago

Thanks Phillip!

  1. I mean pressing ENTER.
philippfromme commented 6 years ago

Adding to 1 you can open the context menu immediately by pressing CMD when clicking on a cell.

Regarding 3 do you mean pressing ENTER while a cell is focussed or while you are editing through the context menu?

benhoffmann commented 6 years ago

1: cool, I didn't know 👍 3: after typing expressions (not using the context menu)

philippfromme commented 6 years ago

In what context are you using the DMN modeling? On ENTER the cell below should be selected, on ENTER + SHIFT the cell above should be selected.

benhoffmann commented 6 years ago

Ah, sorry, I missed that this does not work on the last rule. I would have expected that pressing ENTER adds a new row after the last one. Don't know if that is a valid use case, but that's the reason why it didn't work when I tried it.

philippfromme commented 6 years ago

I totally agree with you, we've already thought about this.

I've created an issue for that: https://github.com/bpmn-io/dmn-js/issues/345