camunda / camunda-platform-helm

Camunda Platform 8 Self-Managed Helm charts
https://docs.camunda.io/docs/self-managed/overview/
Apache License 2.0
74 stars 138 forks source link

[ISSUE] The comments explaining the use of existingSecret settings are incorrect #762

Open daniel-ewing opened 1 year ago

daniel-ewing commented 1 year ago

Describe the issue:

The comments explaining the use of existingSecret settings are incorrect for all settings like: global.identity.auth.[componentName].existingSecret. See, for example values.yaml#L128-L129, which states:

        # Identity.auth.connectors.existingSecret can be used to use an own existing secret. If not set a random secret is generated.
        # The existing secret should contain an `connectors-secret` field, which will be used as secret for the Identity-Connectors communication.

Actual behavior:

If used this way, global.identity.auth.[componentName].existingSecret contains the actual value of the secret stored in the [componentName]-secret field of an auto-generated secret with the name [deploymenyName]-[componentName]-secret.

Expected behavior:

The comment should accurately explain the behavior described above and the values.yaml should also explain that if you want to provide the name of an existing secret that contains a [componentName]-secret field, the correct syntax is global.identity.auth.[componentName].existingSecret.name

How to reproduce:

Try it.

Logs:

Not relevant.

Environment:

proxyvert commented 1 year ago

hi @daniel-ewing, I have the same issue https://github.com/camunda/camunda-platform-helm/issues/760

floric commented 1 year ago

See https://github.com/camunda/camunda-platform-helm/issues/760#issuecomment-1628790337 :) good luck