Review of ci cd blueprint

camunda / camunda-platform-tutorials

Step-by-step tutorials to guide Camunda Platform 8 users to certain use cases end-to-end

16 stars 23 forks source link

Review of ci cd blueprint #61

Closed till-stadtler closed 7 months ago

till-stadtler commented 7 months ago

Hi,

I reviewed the CI CD Blueprint in the ci-cd-blueprint branch. This Pull Request is for the ci-cd-blueprint branch, not main.

Changes

aesthetics
removed unnecessary multi-instance embedded subprocesses -> used multi-instance REST connector instead
(REST connector can be updated)
changed structure of "Get file details" embedded subprocess in "Retrieve file metadata from Web Modeler API"

The functionality should not be impacted by these changes.

wollefitz commented 7 months ago

Hey @till-stadtler! Thank you so much for your thorough review - you cleaning up the diagram in fact made me realize a small bug where no kick off milestone was created for DMN files which should be the case. I also updated all connectors to the latest versions and adjusted the ids of some tasks/start events/end events to be human readable.

Could you have another quick look?

till-stadtler commented 7 months ago

I made some minor adjustments in the position of texts, and the boundary of an embedded subprocess. Ready to be merged from my point of view!