camunda / camunda-tf-eks-module

Terraform modules targeting AWS EKS Cluster creation for Camunda 8 Self-Managed usage on AWS
https://docs.camunda.io/docs/self-managed/setup/deploy/amazon/amazon-eks/eks-terraform/
Apache License 2.0
1 stars 0 forks source link

test: implement s3 backend state in tests #89

Closed leiicamundi closed 1 week ago

leiicamundi commented 1 month ago

This PR leverage S3 backend as a tfstate storage. Related to https://github.com/camunda/team-infrastructure-experience/issues/306

For the reviewer, I'm unsure about the consequences of this implementation in the multiregion. (cc @Langleu)

leiicamundi commented 1 week ago

Thanks for pointing this out, @Langleu.

I’ve made the following changes:

Langleu commented 1 week ago

I've disabled auto-merge for now.

Langleu commented 1 week ago

Overall, looks good! I think the only thing missing is alignment of the regions, as mentioned in https://github.com/camunda/infraex-terraform/pull/46 that the bucket would end up in eu-central-1 which isn't an issue but everything is built around a single AWS region. The only difference would be to have an input for the backend region vs execution region.