RabbitMQ Connector does unnecessary message unsescape action.

[Zapolski]

Describe the Bug

I use out-of-the-box RabbitMQ Connector. Message for sending contains string fields with escaped symbols, like:

{
   "data": {
       "company": "LTD \"Three bears\""
   }
}

Connector sends my message but consumer receives wrong message and fells with MessageConversionException. There’s a message which consumer receives:

{
   "data": {
       "company": "LTD "Three bears""
   }
}

All symbols "\" disappeared. Connector’s source code contains logic with unescaping json.

Steps to Reproduce

1. Prepare message object for sending by RabbitMQ connector. Object must contain field with escaped symbols. For example:

   {
   "data": {
      "company": "LTD \"Three bears\""
   }
   }

2. Use RabbitMQ connector for sending message.

Expected Behavior

I expect the same message in my RabbitMQ CONSUMER, message should be without any transformation.

Environment

• OS: [Linux Ubuntu]
• Library version: [RabbitMQ Connector io.camunda.connectors.RabbitMQ.v1 version 5]
• Camunda version: [e.g. 8.4. (self-managed)]

Camunda 8 forum topic

[sbuettner]

As discussed in our team meeting we will remove unnecessary unescaping from Connectors in the next alpha.

[mathias-vandaele]

After testing, removing .map(StringEscapeUtils::unescapeJson) L65 io.camunda.connector.rabbitmq.outbound.MessageUtil corrects the issue. I am not so sure about removing it as it might have been added for a valid reason, any thoughts @sbuettner ?

[johnBgood]

I'm posting the forum comment I made here for visibility:

It is due to Zeebe escaping characters. Looking at this ticket, it seems that it might be resolved. If so, we will remove the unescapes in our connectors.

The way I see it, we might remove any unescaping (not only in the RabbitMQ connector), but let's wait for @sbuettner or @chillleader opinions.

[chillleader]

Right, that Zeebe issue was the reason we added it there. If the escaping issues are gone, we no longer need the workaround.

[mathias-vandaele]

@chillleader Should I make an update and modify it in every connector ?

[chillleader]

Yes please - although I imagine there might be some corner cases where we might decide to keep unescaping for certain reasons (or maybe not, let's see during the review 🙂). But in general I think we should remove it from all connectors now.

[sbuettner]

Yes, lets remove unnecessary escaping but not backport it as previous zeebe releases faced this issue.