search

camunda / dmn-scala

DMN engine written in Scala
Apache License 2.0
34 stars 15 forks source link

fix: Handle the invocation of a non-existing decision #206

Closed saig0 closed 1 year ago

saig0 commented 1 year ago

Description

If a decision is invoked with a non-existing decision id, the engine returns a failure with an empty audit log. This caused an exception because the audit log couldn't handle an empty list.

Remove the public properties rootEntry and requiredEntries from the audit log. These properties don't work if the audit log entries are empty.

Note that the property rootEntry may contain an audit log entry but no from the root decision. If the evaluation of a required decision fails, the engine doesn't add an entry for the root decision.

Related issues

closes #135

saig0 commented 1 year ago

@remcowesterhoud thank you for your fast review. :bow:

Do we have bors here? < I guess not smile

Not yet. But it would be nice to have. :sweat_smile: