search

camunda / dmn-scala

DMN engine written in Scala
Apache License 2.0
34 stars 15 forks source link

Output ids in cycle #212

Open nhomble opened 1 year ago

nhomble commented 1 year ago

Is your feature request related to a problem? Please describe. It is difficult to determine the cycle in a DMN from the current message in the Camunda modeler. My only way to figure this out is to run the parser locally and set a breakpoint.

      Left(Failure(
        "Invalid DMN model: Cyclic dependencies between decisions detected."))

Describe the solution you'd like I'd like to see the ids of the impacting decisions added to the failure message.

Related issues https://github.com/camunda/dmn-scala/pull/207

saig0 commented 1 year ago

@nhomble thank you for reporting. :+1:

This sounds like a reasonable improvement. But maybe not the most important one. I assume that the cyclic dependency is obvious when looking at the DRD. But feel free to share an example to demonstrate the issue.

nhomble commented 1 year ago

I agree that the DRD should be sufficient which is why I created https://github.com/camunda/dmn-scala/issues/213 out of surprise.