camunda / element-templates-json-schema

JSON Schema for (Camunda) Element Templates
10 stars 7 forks source link

Support property condition: `simple` #55

Closed barmac closed 2 years ago

barmac commented 2 years ago
"condition": {
  "examples": [
    {
      "type": "simple",
      "property": "httpMethod",
      "equals": "GET"
    },
    {
      "type": "simple",
      "property": "httpMethod",
      "oneOf": [ "POST", "PUT", "DELETE" ]
    }
  ]
}

Closes #54

barmac commented 2 years ago

Note for reviewers: This PR is targeted at next. This is the branch from which we will release an alpha version of the schema. If we need to do any breaking changes, we will do it on next. When condition schema is settled, we will merge to master.

nikku commented 2 years ago

Should we not adopt develop and master/main? We have it in some parts of our tooling, and it works.

barmac commented 2 years ago

We could do that, sure.

barmac commented 2 years ago

next -> develop is done

barmac commented 2 years ago

Thanks for the review. I will add code change you suggested and the test cases.

barmac commented 2 years ago

Ready for second round.