camunda / feel-scala

FEEL parser and interpreter written in Scala
https://camunda.github.io/feel-scala/
Apache License 2.0
123 stars 50 forks source link

Adopt cycle() function from Zeebe #432

Closed saig0 closed 4 weeks ago

saig0 commented 2 years ago

Is your feature request related to a problem? Please describe. I can use the cycle() function in the FEEL engine. Currently, the function is implemented in Zeebe (see here). It is used to create a string for repeating intervals.

For maintainability, it makes sense to move the function in the FEEL engine.

Describe the solution you'd like

Related issues

saig0 commented 1 year ago

I challenge the need for this function. As a user, I can easily produce the string for the repeated interval using string concatenation. For example:

"R5/" + string(@"P2D")

"R/" + string(@"PT2H")

I suggest deprecating this function in the code and removing it from the C8 documentation.

saig0 commented 4 weeks ago

The function was removed from the docs since version 8.3. :white_check_mark:

It is unlike that the function is still in use. However, we can't remove it from Zeebe in case that an older process used the function.

So, nothing more to do.