search

camunda / feel-scala

FEEL parser and interpreter written in Scala
https://camunda.github.io/feel-scala/
Apache License 2.0
119 stars 46 forks source link

fix: Double quotes in string literal are escaped #780

Closed saig0 closed 6 months ago

saig0 commented 6 months ago

Description

Handle double quotes in string literals properly. Currently, the quotes are escaped but should not.

// expression:
"hello \"FEEL\"!"

// result in current version: 
"hello \\\"FEEL\\\"!"

// result with the change:
"hello \"FEEL\"!"

Related issues

closes #778

github-actions[bot] commented 6 months ago

Backport failed for 1.16, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 1.16
git worktree add -d .worktree/backport-780-to-1.16 origin/1.16
cd .worktree/backport-780-to-1.16
git switch --create backport-780-to-1.16
git cherry-pick -x f71719978cb122d019cad7b2002ef1755fa83a76 630ce93b8f250bb63dda2a5781125b2927536be3
github-actions[bot] commented 6 months ago

Successfully created backport PR for 1.17: