search

camunda / feel-scala

FEEL parser and interpreter written in Scala
https://camunda.github.io/feel-scala/
Apache License 2.0
123 stars 50 forks source link

feat: Make the FeelEngineBuilder available from Java/Kotlin #832

Closed vicmosin closed 1 month ago

vicmosin commented 5 months ago

Description

Refactored implementation

Related issues

closes #724

vicmosin commented 5 months ago

Mh.. not sure what causes this:

[INFO] Comparing to version: 1.17.5
Error:  7002: org.camunda.feel.api.FeelEngineBuilder: Method 'public scala.Function1 curried()' has been removed
Error:  7002: org.camunda.feel.api.FeelEngineBuilder: Method 'public scala.Function1 tupled()' has been removed
saig0 commented 5 months ago

@vicmosin the build failures are reported by the Clirr plugin. By adding an object to the builder, it changes the Scala internal signature. However, this is okay. We need to exclude these changes in the plugin configuration here.

saig0 commented 4 months ago

@vicmosin do you want to continue contributing to this PR? The last update was one month ago.

vicmosin commented 4 months ago

@saig0 I am sorry, I've been busy last month, will be available at the beginning of the june. If it's urgent, feel free to take over. Thnx

saig0 commented 4 months ago

@vicmosin thank you for the update. :+1: No need to rush. June is fine. :sun_with_face:

vicmosin commented 1 month ago

I am sorry, totally forgot about this one 🤦

saig0 commented 1 month ago

@vicmosin no problem. :laughing: It's merged. :rocket: