camunda / feel-scala

FEEL parser and interpreter written in Scala
https://camunda.github.io/feel-scala/
Apache License 2.0
124 stars 51 forks source link

fix: `string()` function can handle a context with custom value types #833

Closed mustafadagher closed 7 months ago

mustafadagher commented 7 months ago

Description

Extend string() function to parse custom contexts and lists with custom value types

Related issues

closes #804

saig0 commented 7 months ago

Backport failed for 1.16, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 1.16
git worktree add -d .worktree/backport-833-to-1.16 origin/1.16
cd .worktree/backport-833-to-1.16
git switch --create backport-833-to-1.16
git cherry-pick -x 621e61ba2148e8cc29888bcd5448ca3410fc87ff e099a8683e73df417b26652c13938c67959ee247
saig0 commented 7 months ago

Git push to origin failed for 1.17 with exitcode 1

saig0 commented 7 months ago

Backport failed for 1.16, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 1.16
git worktree add -d .worktree/backport-833-to-1.16 origin/1.16
cd .worktree/backport-833-to-1.16
git switch --create backport-833-to-1.16
git cherry-pick -x 621e61ba2148e8cc29888bcd5448ca3410fc87ff e099a8683e73df417b26652c13938c67959ee247
saig0 commented 7 months ago

Git push to origin failed for 1.17 with exitcode 1

saig0 commented 7 months ago

Backport failed for 1.16, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 1.16
git worktree add -d .worktree/backport-833-to-1.16 origin/1.16
cd .worktree/backport-833-to-1.16
git switch --create backport-833-to-1.16
git cherry-pick -x 621e61ba2148e8cc29888bcd5448ca3410fc87ff e099a8683e73df417b26652c13938c67959ee247
saig0 commented 7 months ago

Git push to origin failed for 1.17 with exitcode 1

saig0 commented 6 months ago

@korthout the backport action went crazy for this PR. Please have a look if this is a known bug or something wrong in the configuration. Thank you. :fire:

saig0 commented 6 months ago

Okay, I guess the backport loop was caused by the comment that contains the term /backport. This is a known issue and should be fixed by adjusting the configuration (ref). :+1: I'll give it a try.

saig0 commented 6 months ago

No need to backport the fix to version 1.16 because the string() function supports context values only since version 1.17.