camunda / linting

Linting for the Camunda Desktop and Web Modeler
MIT License
2 stars 2 forks source link

Add New Rules #79

Closed nikku closed 1 year ago

nikku commented 1 year ago

Cf. https://github.com/camunda/bpmnlint-plugin-camunda-compat/blob/main/CHANGELOG.md#250


Related to https://github.com/camunda/camunda-modeler/issues/3793 Closes https://github.com/camunda/linting/issues/81

philippfromme commented 1 year ago

I am currently completing and reviewing this pull request.

philippfromme commented 1 year ago

Maybe @marstamm can have a look since I did quite some work on this and don't want to merge it without double-checking.

marstamm commented 1 year ago

Will have a look

marstamm commented 1 year ago

[q] how does the secret rule work for inputs? In the test case in camunda-compat, it is marked as valid with source="{{}}". However, we enforce FEEL expressions for inputs, so ={{secrets.FOO}} causes a syntax error. Is ="{{secrets.FOO}}" the correct way then?

philippfromme commented 1 year ago

[q] how does the secret rule work for inputs? In the test case in camunda-compat, it is marked as valid with source="{{}}". However, we enforce FEEL expressions for inputs, so ={{secrets.FOO}} causes a syntax error. Is ="{{secrets.FOO}}" the correct way then?

Yes, from a user's perspective only ="{{secrets.foo}}" would work. For the sake of the test case which only uses the secrets rule FEEL isn't relevant.

marstamm commented 1 year ago

Makes sense, thanks you!

marstamm commented 1 year ago

Looks good to merge to me after we adjust the error messages