Closed nikku closed 1 year ago
I am currently completing and reviewing this pull request.
Maybe @marstamm can have a look since I did quite some work on this and don't want to merge it without double-checking.
Will have a look
[q] how does the secret rule work for inputs? In the test case in camunda-compat, it is marked as valid with source="{{}}"
. However, we enforce FEEL expressions for inputs, so ={{secrets.FOO}}
causes a syntax error. Is ="{{secrets.FOO}}"
the correct way then?
[q] how does the secret rule work for inputs? In the test case in camunda-compat, it is marked as valid with
source="{{}}"
. However, we enforce FEEL expressions for inputs, so={{secrets.FOO}}
causes a syntax error. Is="{{secrets.FOO}}"
the correct way then?
Yes, from a user's perspective only ="{{secrets.foo}}"
would work. For the sake of the test case which only uses the secrets
rule FEEL isn't relevant.
Makes sense, thanks you!
Looks good to merge to me after we adjust the error messages
secrets
rule and adjusts error messageno-propagate-all-parent-variables
rule and adjusts error messagelink-event
rule and adjusts error messageCf. https://github.com/camunda/bpmnlint-plugin-camunda-compat/blob/main/CHANGELOG.md#250
Related to https://github.com/camunda/camunda-modeler/issues/3793 Closes https://github.com/camunda/linting/issues/81