search

camunda / zeebe-bpmn-moddle

Zeebe moddle extensions for BPMN 2.0
MIT License
14 stars 7 forks source link

feat: add `FormDefinition#formId` property #49

Closed philippfromme closed 10 months ago

philippfromme commented 11 months ago

Adds optional FormDefinition#formId property required by https://github.com/bpmn-io/bpmn-js-properties-panel/issues/949.

Example XML:

<bpmn:startEvent id="StartEvent_1">
  <bpmn:extensionElements>
    <zeebe:formDefinition formId="MY_FORM" />
  </bpmn:extensionElements>
</bpmn:startEvent>

Closes #48

Related to https://github.com/bpmn-io/bpmn-js-properties-panel/issues/949 Product Hub Issue: https://github.com/camunda/product-hub/issues/419

philippfromme commented 11 months ago

We need to clarify https://docs.google.com/document/d/13FTH_lDAJYnQf_YG15szJas7GsGGcNF-LT-mqTSCOf0/edit?disco=AAAA3o49-3k before merging this.

nikku commented 11 months ago

Thanks for flagging this. I reviewed the attached document and wonder why we introduce a new thing in the first place.

Additionally, considering the user journey I'd suggest that we emphasize referencing over embedding, and change labels accordingly. The default could be Camunda Form (referenced) while the current one could change to Camunda Form (embedded). Alternatively the default could stay embedded. From what I understand we want to get users away from using embedded forms due to bad UX?

philippfromme commented 10 months ago

XML has been clarified. An optional formId attribute will be added.