Test no response when no request metadata

ana-vinogradova-camunda commented 6 months ago

Description

This PR is related to https://github.com/camunda/zeebe/issues/15649. This was fixed and backported to 8.4 and 8.3 this week.

Adding an optional request listener to GrpcResponseWriter tryWriteResponse method in order to verify the response is not send when there is no corresponding request. So far we are only aware that this could happen with Intermediate Signal Throw events.

If we have similar cases in the future we can address them then. Please let me know if that's OK.

Related issues

closes #1011

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

[x] The changes are backwards compatibility with previous versions
[ ] If it fixes a bug then PRs are created to backport the fix

Testing:

[x] There are unit/integration tests that verify all acceptance criterias of the issue
[x] New tests are written to ensure backwards compatibility with further versions
[ ] The behavior is tested manually

Documentation:

[ ] Javadoc has been written
[ ] The documentation is updated

github-actions[bot] commented 6 months ago

Test Results

50 files ±0 50 suites ±0 1m 44s :stopwatch: ±0s 136 tests +1 136 :white_check_mark: +1 0 :zzz: ±0 0 :x: ±0 432 runs +3 432 :white_check_mark: +3 0 :zzz: ±0 0 :x: ±0

Results for commit c4e3cc3c. ± Comparison against base commit e179b3b5.

:recycle: This comment has been updated with latest results.

ana-vinogradova-camunda commented 6 months ago

@tmetzke Zeebe fix related to that issue was back-ported to 8.4 and 8.3

tmetzke commented 6 months ago

@tmetzke Zeebe fix related to that issue was back-ported to 8.4 and 8.3

Fair enough, but there are versions of 8.4 before the backport you could try that test with, right? It's just another verification step to ensure we're testing something here that didn't work before and now works after the fix.

ana-vinogradova-camunda commented 6 months ago

@tmetzke Zeebe fix related to that issue was back-ported to 8.4 and 8.3

Fair enough, but there are versions of 8.4 before the backport you could try that test with, right? It's just another verification step to ensure we're testing something here that didn't work before and now works after the fix.

Testing done, the test fails on versions before the backport.

camunda / zeebe-process-test