canada-ca / accelerators_accelerateurs-gcp

[GCP] Tools and templates to accelerate GC service delivery. Outils et modèles pour accélérer la prestation de services du GC.
MIT License
10 stars 8 forks source link

Ready to Merge ---- Adjust script/terraform deployment for single session automation with rerun capability and pre/post roles/permissions set/verify - Claudia and Michael recent triage #26

Closed fmichaelobrien closed 2 years ago

fmichaelobrien commented 2 years ago

the following patch was triaged on 2 live deployments and reverified on a clean cloud identity organization account

see test details in https://github.com/canada-ca/accelerators_accelerateurs-gcp/issues/24

Claudia and Michael triage

fixes (will get past permissions issues running terraform)

fmichaelobrien commented 2 years ago

I'll rebase shortly today - with the other PRs that were consolidated into this larger PR...

fmichaelobrien commented 2 years ago

Branch rebased - PR ready for merge

fmichaelobrien commented 2 years ago

Team, I really appreciate the review and merge - thank you very much. /michael