canada-ca / blogue-canada-ca-blog

Canada.ca blog: Digital Transformation Office | blogue de Canada.ca - Bureau de la transformation numérique
https://blog.canada.ca
MIT License
4 stars 8 forks source link

Add Font Awesome CSS to the Jekyll template #112

Open prycrane opened 1 year ago

prycrane commented 1 year ago

Please add the link to the font awesome CSS to the Jekyll template.

https://use.fontawesome.com/releases/v5.15.4/css/all.css

delisma commented 1 year ago

Would you want it as a default on all the pages or as a property on page-to-page basis?

prycrane commented 1 year ago

That's a good question. I don't think there is much harm in making it available, but if it's rarely used, then it's a waste. Why don't we put it at the page level, then people can use it with intension.

delisma commented 1 year ago

Agree. And I'm thinking of a feature that I could push to GCWeb-Jekyll in the future where you could have a property for Font Awesome (FA) itself and you could choose which version of FA to use on your page. That could facilitate the migration to newer version of FA in the long run.