search

canada-ca / design-system-systeme-conception

Experimental/test repo for the Canada.ca design library - the official repo is over here: https://github.com/canada-ca/design-system and experimental repo can be viewed at:
https://design.alpha.canada.ca/
MIT License
10 stars 7 forks source link

Subway nav - Fix the index view (not showing up) #125

Open afhill opened 3 years ago

afhill commented 3 years ago

The example doesn't seem to actually show the subway navigation?

Also, would be helpful to understand when and how this is different from the service initiation pattern?

jkshapiro commented 3 years ago

See also #89

RonStLouis commented 3 years ago

Does this pattern conflict with the Style Guide that page titles should be unique? https://www.canada.ca/en/treasury-board-secretariat/services/government-communications/canada-content-style-guide.html#wp5-1

quidampepin commented 3 years ago

@RonStLouis the guidance in the style guide needs clarification (does it talk about the metadata title, or the H1?). In this case, the page titles (metadata) should still be unique, as they should include both the group name and the specific name.

quidampepin commented 3 years ago

@afhill I know it's been a while, but just seeing this now. The example (https://design.canada.ca/common-design-patterns/subway-navigation.html) does have a JS issue that needs fixing (the index doesn't show). We'll try to fix it soon.