gcharest
commented
3 years ago Looks great! I noticed a missing
I'll be pushing a few little changes:
- switch to HTML file since there is virtually no Markdown content at all in the file (makes for document auto formatting way easier, which helped find the missing tag)
- add a "no open opportunities" note when count of open opportunities equals 0
- Remove commented out HTML since we're not going to use that for a long time, if ever. (still in the history of the project if need be but better off cleaning up the code for better readability and maintenance.)
RachelMuston
The purpose of this PR is to remove the table elements from the opportunities table as it was flagged as not meeting accessibility.
Table elements have been removed and replaced by div and p.
FYI making this change will prevent us from adding filter functionality in the future.
Not sure if how I have coded this is good code. Was a 'hack it 'til it works' situation.
The look of the cards is mostly like the current website although the card header is a lighter grey and the link text is purple. I'd prefer the look we have now (dark grey header and white font) but not sure how to do that.