canadalearningcode / llc-intro-to-browser-extensions

Intro to Browser Extensions with JavaScript
https://ladieslearningcode.github.io/llc-intro-to-browser-extensions/slides-en.html
Other
8 stars 10 forks source link

Update string concatenation example. #10

Closed jrmykolyn closed 6 years ago

jrmykolyn commented 6 years ago

Problem Statement The 'breakdown' which accompanies the string concatenation example uses a combination of variables which have been defined, variables which have not been defined, and strings. This may lead to confusion when explaining or reading over the material.

Solution Update the snippet to:

svinkle commented 6 years ago

This can be thought of as pseudo code to help explain the line of code directly above.

"See this line of code?"

var greetingFull = greeting + " " + greetingTime + "!";

"This is what is happening here…"

"variable 'greetingFull' is being assigned the 'greeting' variable which equates to the string 'Good', plus a space for readability, then the 'greetingTime' variable which equates to 'morning', then we end with an exclamation mark."

This change is not required; closing.

jrmykolyn commented 6 years ago

@svinkle Thanks for reviewing. 👍