search

canalplus / rx-player

DASH/Smooth HTML5 Video Player
https://developers.canal-plus.com/rx-player/
Apache License 2.0
870 stars 132 forks source link

Add `stpp.ttml` text tracker recognition #1555

Closed mkochman closed 1 month ago

mkochman commented 1 month ago

Hi, in project we use stpp.ttml codec for text trackers and I see that in RxPlayer code this direct string is not recognized. switch (codecs.toLowerCase()) { case "stpp": // stpp === TTML in MP4 case "stpp.ttml.im1t": return "ttml"; case "wvtt": // wvtt === WebVTT in MP4 return "vtt"; }

So far I have created forked code with added stpp.ttml and pushed it on cdn, it seems to work as expected. I would appreciate it if stpp.ttml parsing was added to the main package of RxPlayer by default.

So far I have locally created PR with that change but I cannot push it to repo.

peaBerberian commented 1 month ago

Hi,

Thanks for the issue.

So far I have locally created PR with that change but I cannot push it to repo.

PRs from people outside an organization is kind of awkward on GitHub, you have to fork the project (e.g. through GitHub's interface), and open the PR from there (your fork). GitHub will propose a base on which the update should be merged, and by default it will select the base project (this one).

mkochman commented 1 month ago

Thank you ;)

Florent-Bouisset commented 1 month ago

fixed by https://github.com/canalplus/rx-player/pull/1557