search

canalun / brick-break-anywhere

let's break bricks anywhere!
63 stars 3 forks source link

Enhance reload #13

Closed igrep closed 1 month ago

igrep commented 2 months ago

Sorry, but this pull request is complex: I could make a separate PR for each of the commits. As the title suggests, the most important change is related to reloading (https://github.com/canalun/brick-break-anywhere/pull/13/commits/e5ead659cf3f13dc71e02c865776f08bf54774f4 and https://github.com/canalun/brick-break-anywhere/pull/13/commits/31f0c7005447b8c8b558a61e2b4f7123e16c2cc5). See the commit message for details. Feel free to reject one of them if you don't like. I'll rebase to remove it soon.

igrep commented 2 months ago

Sorry! This change doesn't look working as expected in some cases. Convert back to draft.

canalun commented 2 months ago

oh, really!? I was about to approve it just now🤣 Thank you for fixing it! Looking forward to it, and sorry for my late review.

igrep commented 2 months ago

Thank you for reviewing. Fixed with 12c7f5388700581a373decda998a4bffbf957668! And sorry that my testing after 31f0c7005447b8c8b558a61e2b4f7123e16c2cc5 was incomplete.

igrep commented 1 month ago

🙏 Let me remind you because I may be completing a new PR whose commits are added from this branch in a week. The changes don't actually depend on this PR, but include a conflict.

canalun commented 1 month ago

@igrep sorry, I kept you waiting...! I'm reviewing it tonight, got it!

canalun commented 1 month ago

Thank you for patience and contribution!