canalun / brick-break-anywhere

let's break bricks anywhere!
66 stars 3 forks source link

Make (equivalent for) dragAndMoveBall available again #15

Closed igrep closed 2 months ago

igrep commented 4 months ago

This is still draft because I left a several things below and I want to show you before completing to reduce the risk in case of refusal. FEEDBACK WELCOME!

Background

When I first play with brick-block-anywhere on my website, I found a bug that could be a good chance for me to learn the browser's behavior. This feature is very useful for reproducing the bug and testing after fixing it.

Changes Summary

Screenshot

bba-control-by-mouse

canalun commented 3 months ago

@igrep Apologies for my late reply. After a busy month, now I have time to review this PR. I like your idea! So could you please go for it? Sorry for late response. (FYI. I've left some comments, thank you for checking them!)

canalun commented 3 months ago

And I like your branch name :)

igrep commented 3 months ago

And I like your branch name :)

Thank you! 😁 To tell the truth, I couldn't make up a good name for controlMode: "mouse" at first. Then I decided to give a name that sounds something super because it breaks the nature of the brick-break game. "God mode" might be more suitable, but "God" could be so religious that I couldn't determine it's safe. "Ninja" would have no such a problem and everyone loves it by contrast!

And the prefix "2" means it's just the second try 😅 .

igrep commented 2 months ago

NOTE: I force-pushed https://github.com/canalun/brick-break-anywhere/commit/3aad11f1f64cb45f3fb7484bde5ad944b15cce5e because https://github.com/canalun/brick-break-anywhere/commit/80770191c2d8300b39a4786fff26eb311989a470 doesn't work because only the declaration of ball is renamed.