search

canboat / canboatjs

Native javascript NMEA 2000 decoder and encoder
Apache License 2.0
95 stars 39 forks source link

Handle NMEA0183v4 Tag Block for PCDIN and MXPGN sentences #257

Closed macjl closed 10 months ago

macjl commented 11 months ago

Hello,

Related to this bug : https://github.com/SignalK/signalk-server/issues/1645

CanboatJS seems to discard NMEA0183 sentences when there contain Tag Blocks. Examples : 

\s:serial,c:1696759211*3D\$MXPGN,01F200,2838,00441FFFFF7FFFFF*12
\s:serial,c:1696759212*3E\$MXPGN,01F214,6824,03BA0A0A00FFFF73*1C
\s:serial,c:1696759212*3E\$MXPGN,01F214,6824,0283050C00FFFF73*63
\s:serial,c:1696759212*3E\$PCDIN,01F200,B35A7B99,38,003A1FFFFF7FFFFF*2A
\s:serial,c:1696759212*3E\$PCDIN,01F201,B35A79DF,38,00FFFFFFFFDB8D6E05FF7FC80D4800FFFFFFFF7F000000007F7F*29
\s:serial,c:1696759212*3E\$PCDIN,01F214,B35A7A3B,E0,008805FF7FFFFF7E*51
\s:serial,c:1696759212*3E\$PCDIN,01F214,B35A7A3B,E0,0183055500FFFF7E*2A

Without Tag Blocks, these sentences are correctly understood by CanboatJS.

sbender9 commented 10 months ago

@macjl fix released in v2.5.5 , can you try it out?