search

cancerDHC / ccdh-terminology-service

CCDH Terminology and Mapping Service
3 stars 4 forks source link

Enum names in the CRDCH LinkML model will be changing soon #45

Closed gaurav closed 2 years ago

gaurav commented 3 years ago

Note that enumeration names in the form enum_CCDH_* will change to enum_CRDCH_* once https://github.com/cancerDHC/ccdhmodel/pull/68 is completed and merged. You might need to update your code when that happens.

joeflack4 commented 3 years ago

@jiaola Should we discuss?

Labeled as ease1 and urgency1 because I think probably both quite easy and also quite urgent, as it should cause breaking changes for us. Therefore I labeled as 'bug', even though it's not really a logic error on the service end.

gaurav commented 3 years ago

I don't remember what this issue refers to any more, but the Terminology Service seems to be working for CRDC-H model generation, so I don't think it's relevant any more. Should I go ahead and close this issue?

joeflack4 commented 3 years ago

@gaurav I think that's a good idea! closing.

joeflack4 commented 2 years ago

@gaurav Looks like reason this wasn't an issue is because the code base hadn't actually been updated in awhile. After being updated it broke.

gaurav commented 2 years ago

Lol

joeflack4 commented 2 years ago

Fixed. This had to do not with any of the terminology service code itself, but it was caused by the neo4j docker container not being correctly refreshed upon new deployment.