(1) PDC test server importer broken, (2) git submodule configuration ok?

[joeflack4]

Tasks

• [x] 1. PDC: test server importer broken
• [x] 2. git submodule configuration ok?

Description

Issue (2) is an issue in and of itself, but it may also be the cause of (1), which is why I'm grouping them together.

1. PDC: test server importer broken

Action: Booting docker container and running python -m ccdh.importers.importer and check https://test.terminology.ccdh.io/models Expected behavior: should show PDC Actual behavior: doesn't show PDC

2. git submodule configuration ok?

Production env

cd ccdh-terminology-service; git submodule

 5c3ac5d167786ed2d94ec672ddf67adfad4e7d45 crdc-nodes/HTAN-data-pipeline (remotes/origin/main)
+091ffa25f73f19ee0151e0b1179d3ae864ef7d32 crdc-nodes/PDC-Public (heads/master)
+6457a448dd1cb583cb88f8323b72a57f41b48be5 crdc-nodes/gdcdictionary (2.1.1-rc.2-47-g6457a44)
+bfad07fba992d580b8cd4dc49665866aecb50d57 crdc-nodes/icdc-model-tool (v2.0.0-7-gbfad07f)

git status

HEAD detached at origin/master
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)
    modified:   crdc-nodes/PDC-Public (new commits)
    modified:   crdc-nodes/gdcdictionary (new commits)
    modified:   crdc-nodes/icdc-model-tool (new commits, modified content)

no changes added to commit (use "git add" and/or "git commit -a")

cd crdc-nodes/PDC-Public/; git branch

* (HEAD detached at 091ffa2)
  master

git log

commit 091ffa25f73f19ee0151e0b1179d3ae864ef7d32 (HEAD, master)
Author: Ngoc Nguyen <ngoc.nguyen@esacinc.com>
Date:   Tue May 18 23:03:45 2021 -0400

    Checked in release v1.1.5

git remote -v

origin  https://github.com/esacinc/PDC-Public (fetch)
origin  https://github.com/esacinc/PDC-Public (push)

Test env

cd ccdh-terminology-service-test; git submodule

-5c3ac5d167786ed2d94ec672ddf67adfad4e7d45 crdc-nodes/HTAN-data-pipeline
-c00e5e1e145d71e0be008f0bd816a955bf96bd3d crdc-nodes/PDC-Public
-92a77bc7319f55e4ad263c4b1d24c7a0e11186ee crdc-nodes/gdcdictionary
-b3e078a1407299800dc45edf2850eb3a0674ea8f crdc-nodes/icdc-model-tool

git status

HEAD detached at origin/master
nothing to commit, working tree clean

cd crdc-nodes/PDC-Public/; git branch

* (HEAD detached at origin/master)
  issue_40-test_server

git log

Author: joeflack4 <joeflack4@gmail.com>
Date:   Mon Aug 23 17:31:19 2021 -0400

    Updates
    - Updated build script & config.py with some .env changes in order to get build to pass. Needed to also update .env file locations on the server and create some symlinks in order to get things to work correctly server side.

git remote -v

joeflack4   git@github.com:joeflack4/ccdh-terminology-service.git (fetch)
joeflack4   git@github.com:joeflack4/ccdh-terminology-service.git (push)
origin  git@github.com:cancerDHC/ccdh-terminology-service.git (fetch)
origin  git@github.com:cancerDHC/ccdh-terminology-service.git (push)

Discussion

Questions

• Why does test env show PDC submodule, but when inside the folder, shows git info for ccdh-terminology-service?
• Is this setup the reason that issue (1) is happening for test env?
• Should we be updating the submodules in the production env?
• Anything else 'git submodule related' in production env that should change?
• Anything else 'git submodule related' in test env that should change?

[joeflack4]

I think this is fixed. check in the deploy