search

cancerDHC / ccdhmodel

CRDC-H model in LinkML, developed by the Center for Cancer Data Harmonization (CCDH)
https://cancerdhc.github.io/ccdhmodel/
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

openpyxl==3.0.8 is not available (deleted version) #120

Closed jooho-lee-kim closed 3 years ago

jooho-lee-kim commented 3 years ago

Pipfile.lock requires openpyxl==3.0.8, but the version 3.0.8 is deleted (see https://openpyxl.readthedocs.io/en/stable/changes.html#brown-bag).

3.0.9 (2021-09-22) is the most recent version.

gaurav commented 3 years ago

Oh man, is this why we were having weird openpyxl issues last week? Good find!

@jooho-lee-kim This should be relatively easy to fix: if you create a branch, run pipenv update, commit the changes, and then create a GitHub pull request with those changes, that should fix this issue. Would you like to take this on as a first issue? If not, no worries, I'll get it fixed quickly!

(I continue to be grouchy that somebody thought it would be a good idea to delete a published package, which is a terrible idea! So annoying.)

jooho-lee-kim commented 3 years ago

My environment is not properly setup yet. I will get my new Mac laptop sometime this week. Also, pipenv update failed on my Windows machine. @gaurav Can you fix this issue? Thanks!

(yeah, openpyxl has several deleted versions. IT IS annoying to fix on our end.)

gaurav commented 3 years ago

Oops, I just realized that this was already fixed in PR 117 (https://github.com/cancerDHC/ccdhmodel/pull/117/commits/12c0ff140ec62521f2e9b92966afa5553287b484) -- it just hadn't been merged into main for some reason. I'll go ahead and close this issue.