search

cancerDHC / ccdhmodel

CRDC-H model in LinkML, developed by the Center for Cancer Data Harmonization (CCDH)
https://cancerdhc.github.io/ccdhmodel/
BSD 3-Clause "New" or "Revised" License
16 stars 8 forks source link

Implement clean up strategies #128

Open sujaypatil96 opened 3 years ago

sujaypatil96 commented 3 years ago

This PR seeks to implement some of the repo clean up strategies discussed in issue #105. The major change in this PR is the integration of the sheet2linkml package as a dependency in the project, and the consequent removal of the vendor directory which previously housed sheet2linkml.

turbomam commented 3 years ago

I'm OK with the examples-for-discussion → examples directory name change, but I don't remember any discussions bout it. Didn't somebody from outside of the tools group create that directory or contribute to it? Is everyone involved OK with the name change?

turbomam commented 3 years ago

why are we renaming model/→ linkml_model? Is this something that we're going to start doing for most linkml projects that BBOPers contribute to?

sujaypatil96 commented 3 years ago

I'm OK with the examples-for-discussion → examples directory name change, but I don't remember any discussions bout it. Didn't somebody from outside of the tools group create that directory or contribute to it? Is everyone involved OK with the name change?

Hm, I think I did bring it up during one of our meetings, but there wasn't a particularly long discussion about it. That makes sense, I CC the people involved and check if they're okay with the name change.

Edit: There's a discussion thread for the above here.

why are we renaming model/→ linkml_model? Is this something that we're going to start doing for most linkml projects that BBOPers contribute to?

I though it'd be a good idea to rename it to linkml_model since in the same way that we have the crdch_model folder in the repo, which is pretty self explanatory as to what it houses, model was too generic to be semantically useful. Which is why I recommended a change to linkml_model so we know its contents.

turbomam commented 3 years ago

Edit: There's a discussion thread for the above here.

Thanks. We should check with @gaurav and make sure that we're not confusing the examples-for-discussion with examples that come from the example-data repo

gaurav commented 3 years ago

Might overlap with #125